Skip to content

fix: optimize CAN receive timeout timing with perf_counter - #2089

Open
luojiaaoo wants to merge 5 commits into
hardbyte:mainfrom
luojiaaoo:main
Open

fix: optimize CAN receive timeout timing with perf_counter#2089
luojiaaoo wants to merge 5 commits into
hardbyte:mainfrom
luojiaaoo:main

Conversation

@luojiaaoo

Copy link
Copy Markdown
Contributor

Description

Replace time.time() with time.perf_counter() for CAN receive timeout calculations.

perf_counter() is better suited for measuring elapsed time and avoids issues caused by system clock adjustments, while also providing better timing precision for the receive loop.

@mergify

mergify Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@fallenmi fallenmi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the Coveralls action pinned to a full commit SHA. On exact base b4f82ab, all 9 external Actions references are full-SHA pinned; exact head 0cd6639 changes both Coveralls uses to the mutable v2.3.8 tag, making these the only two mutable refs. Moving that tag would change third-party code executed with the workflow token without a reviewed repository diff. v2.3.8 currently resolves to 8d6379e14d29928660c4ba802d8e85393440b329, so please pin that SHA with a version comment (or retain the prior pin). I separately exercised the timeout loop on the exact base and head; both exit correctly, and the live upstream checks are green.

Reviewed with OpenAI Codex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants